linux-kernel - Re: [PATCH] isdn/gigaset: use tasklet_kill in device remove/release process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5093C0B8.6080807@imap.cc>
Date:	Fri, 02 Nov 2012 13:46:48 +0100
From:	Tilman Schmidt <tilman@...p.cc>
To:	Xiaotian Feng <xtfeng@...il.com>
CC:	linux-kernel@...r.kernel.org,
	Xiaotian Feng <dannyfeng@...cent.com>,
	Hansjoerg Lipp <hjlipp@....de>,
	Karsten Keil <isdn@...ux-pingi.de>,
	gigaset307x-common@...ts.sourceforge.net
Subject: Re: [PATCH] isdn/gigaset: use tasklet_kill in device remove/release
 process

Am 31.10.2012 11:44, schrieb Xiaotian Feng:
> Some driver uses tasklet_disable in device remove/release process,
> tasklet_disable will inc tasklet->count and return. If the tasklet
> is not handled yet under some softirq pressure, the tasklet will be
> placed on the tasklet_vec, never have a chance to be excuted. This might
> lead to a heavy loaded ksoftirqd, wakeup with pending_softirq, but
> tasklet is disabled. tasklet_kill should be used in this case.
> 
> Signed-off-by: Xiaotian Feng <dannyfeng@...cent.com>
> Cc: Hansjoerg Lipp <hjlipp@....de>
> Cc: Tilman Schmidt <tilman@...p.cc>
> Cc: Karsten Keil <isdn@...ux-pingi.de>
> Cc: gigaset307x-common@...ts.sourceforge.net 
Acked-by: Tilman Schmidt <tilman@...p.cc>

> ---
>  drivers/isdn/gigaset/interface.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/isdn/gigaset/interface.c b/drivers/isdn/gigaset/interface.c
> index 67abf3f..284c7f3 100644
> --- a/drivers/isdn/gigaset/interface.c
> +++ b/drivers/isdn/gigaset/interface.c
> @@ -544,7 +544,6 @@ void gigaset_if_free(struct cardstate *cs)
>  	if (!drv->have_tty)
>  		return;
>  
> -	tasklet_disable(&cs->if_wake_tasklet);
>  	tasklet_kill(&cs->if_wake_tasklet);
>  	cs->tty_dev = NULL;
>  	tty_unregister_device(drv->tty, cs->minor_index);
> 

-- 
Tilman Schmidt                    E-Mail: tilman@...p.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)




Download attachment "signature.asc" of type "application/pgp-signature" (261 bytes)