linux-kernel - Re: [PATCH 2/2] Staging/media: Use dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+MoWDpYP3LsbYZ82hxKeaGa=o2yOnhExvTFkYomOL-2p4aNoA@mail.gmail.com>
Date:	Fri, 2 Nov 2012 13:56:36 +0100
From:	Peter Senna Tschudin <peter.senna@...il.com>
To:	YAMANE Toshiaki <yamanetoshi@...il.com>
Cc:	Greg Kroah-Hartman <greg@...ah.com>,
	linux-media <linux-media@...r.kernel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] Staging/media: Use dev_ printks in go7007/wis-ov7640.c

On Fri, Nov 2, 2012 at 1:09 PM, YAMANE Toshiaki <yamanetoshi@...il.com> wrote:
> fixed below checkpatch warnings.
> - WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then pr_debug(...  to printk(KERN_DEBUG ...
> - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...
>
> Signed-off-by: YAMANE Toshiaki <yamanetoshi@...il.com>
Tested-by: Peter Senna Tschudin <peter.senna@...il.com>
> ---
>  drivers/staging/media/go7007/wis-ov7640.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/go7007/wis-ov7640.c b/drivers/staging/media/go7007/wis-ov7640.c
> index eb5efc9..fe46374 100644
> --- a/drivers/staging/media/go7007/wis-ov7640.c
> +++ b/drivers/staging/media/go7007/wis-ov7640.c
> @@ -59,12 +59,12 @@ static int wis_ov7640_probe(struct i2c_client *client,
>
>         client->flags = I2C_CLIENT_SCCB;
>
> -       printk(KERN_DEBUG
> +       dev_dbg(&client->dev,
>                 "wis-ov7640: initializing OV7640 at address %d on %s\n",
>                 client->addr, adapter->name);
>
>         if (write_regs(client, initial_registers) < 0) {
> -               printk(KERN_ERR "wis-ov7640: error initializing OV7640\n");
> +               dev_err(&client->dev, "wis-ov7640: error initializing OV7640\n");
>                 return -ENODEV;
>         }
>
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



--
Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/