linux-kernel - Re: linux-next: Tree for Oct 31 (ehci, dbgp)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <5093E0DF02000078000A6102@nat28.tlf.novell.com>
Date:	Fri, 02 Nov 2012 14:03:59 +0000
From:	"Jan Beulich" <JBeulich@...e.com>
To:	"Alan Stern" <stern@...land.harvard.edu>
Cc:	<sfr@...b.auug.org.au>, <rdunlap@...radead.org>,
	<gregkh@...uxfoundation.org>, <linux-kernel@...r.kernel.org>,
	<linux-next@...r.kernel.org>, <linux-usb@...r.kernel.org>
Subject: Re: linux-next: Tree for Oct 31 (ehci, dbgp)

>>> On 02.11.12 at 15:01, Alan Stern <stern@...land.harvard.edu> wrote:
> On Thu, 1 Nov 2012, Jan Beulich wrote:
> 
>> >>> Alan Stern <stern@...land.harvard.edu> 11/01/12 9:39 PM >>>
>> >On Thu, 1 Nov 2012, Jan Beulich wrote:
>> >> >>> Alan Stern <stern@...land.harvard.edu> 11/01/12 4:28 PM >>>
>> >> >Evidently we need to change your new test in
>> >> >drivers/usb/early/ehci-dbgp.c to:
>> >> >
>> >> >#if IS_ENABLED(CONFIG_USB_HCD_EHCI) || defined(CONFIG_USB_CHIPIDEA_HOST)
>> >> >
>> >> >Upcoming changes to ehci-hcd will make this unnecessary in 3.8, but for 
>> >> >now we need it.
>> >> 
>> >> Which tells me that the CONFIG_USB_SUPPORT version would have been
>> >> the better one  (and I would favor that over the ugly variant you suggest
>> >> above).
>> >
>> >I also suggested IS_ENABLED(CONFIG_USB), which is no uglier than what 
>> >you submitted and would also fix this build error.  How about using it 
>> >instead?
>> 
>> Yes, that's better. Question then is - updated original patch or incremental 
> one?
> 
> Greg will probably want an incremental patch, because the original has 
> already been merged.

I actually sent both (the incremental as attachment - I hope that's
going to be acceptable to him) in a submission earlier today.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/