linux-kernel - Re: [PATCH v2] MODSIGN: Add modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ip9o4rpp.fsf@rustcorp.com.au>
Date:	Fri, 02 Nov 2012 13:49:14 +1030
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Josh Boyer <jwboyer@...hat.com>
Cc:	dhowells@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] MODSIGN: Add modules_sign make target

Josh Boyer <jwboyer@...hat.com> writes:

> On Thu, Nov 01, 2012 at 06:03:18PM +1030, Rusty Russell wrote:
>> Josh Boyer <jwboyer@...hat.com> writes:
>> 
>> > If CONFIG_MODULE_SIG is set, and 'make modules_sign' is called then this
>> > patch will cause the modules to get a signature appended.  The make target
>> > is intended to be run after 'make modules_install', and will modify the
>> > modules in-place in the installed location.  It can be used to produce
>> > signed modules after they have been processed by distribution build
>> > scripts.
>> >
>> > Signed-off-by: Josh Boyer <jwboyer@...hat.com>
>> 
>> It's a bit of a niche case, but applied.
>
> Thanks.  Whether you consider RPM built kernels niche or not doesn't
> matter to me.  Having this upstream is one less patch we have to carry
> so I appreciate it a lot.

My comment was more that this relies on eu-strip, because we always
sign modules on installation, so you need eu-strip to *unsign* them
(strip won't do it, BTW).

More general would be a modules_install_unsigned target to match this,
but since noone would use it, let's not write it :)

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/