linux-kernel - Re: [PATCH 2/3] perf tools: Introduce struct hist_browser

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5097DA69.7070505@gmail.com>
Date:	Mon, 05 Nov 2012 08:25:29 -0700
From:	David Ahern <dsahern@...il.com>
To:	Namhyung Kim <namhyung@...nel.org>
CC:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Namhyung Kim <namhyung.kim@....com>,
	Irina Tirdea <irina.tirdea@...il.com>
Subject: Re: [PATCH 2/3] perf tools: Introduce struct hist_browser_timer

On 11/1/12 11:50 PM, Namhyung Kim wrote:
> From: Namhyung Kim <namhyung.kim@....com>
>
> Currently various hist browser functions receive 3 arguments for
> refreshing histogram but only used from a few places.  Also it's only
> for perf top command so that it can be NULL for other (and probably
> most) cases.  Pack them into a struct in order to reduce number of
> those unused arguments.
>
> This is a mechanical change and does not intend a functional change.
>
> Cc: David Ahern <dsahern@...il.com>
> Cc: Irina Tirdea <irina.tirdea@...il.com>
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> ---
>   tools/perf/builtin-annotate.c     |  2 +-
>   tools/perf/builtin-report.c       |  4 ++--
>   tools/perf/builtin-top.c          |  9 +++++---
>   tools/perf/ui/browsers/annotate.c | 27 +++++++++++-------------
>   tools/perf/ui/browsers/hists.c    | 43 +++++++++++++++++----------------------
>   tools/perf/ui/gtk/browser.c       |  4 +---
>   tools/perf/util/annotate.h        |  8 ++++----
>   tools/perf/util/hist.h            | 28 ++++++++++++-------------
>   8 files changed, 58 insertions(+), 67 deletions(-)

Tested-by: David Ahern <dsahern@...il.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/