linux-kernel - Re: [PATCH 3/3] perf report: Postpone objdump check until annotation requested

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5097DA6F.9000501@gmail.com>
Date:	Mon, 05 Nov 2012 08:25:35 -0700
From:	David Ahern <dsahern@...il.com>
To:	Namhyung Kim <namhyung@...nel.org>
CC:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Namhyung Kim <namhyung.kim@....com>,
	Irina Tirdea <irina.tirdea@...il.com>
Subject: Re: [PATCH 3/3] perf report: Postpone objdump check until annotation
 requested

On 11/1/12 11:50 PM, Namhyung Kim wrote:
> From: Namhyung Kim <namhyung.kim@....com>
>
> David reported that current perf report refused to run on a data file
> captured from a different machine because of objdump.  Since the
> objdump tools won't be used unless annotation was requested, checking
> its presence at init time doens't make sense.
>
> Reported-by: David Ahern <dsahern@...il.com>
> Cc: Irina Tirdea <irina.tirdea@...il.com>
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> ---
>   tools/perf/builtin-report.c    |  9 ++-------
>   tools/perf/builtin-top.c       |  3 ++-
>   tools/perf/ui/browsers/hists.c | 22 ++++++++++++++++------
>   tools/perf/util/hist.h         |  7 +++++--
>   4 files changed, 25 insertions(+), 16 deletions(-)

Reviewed-by/Tested-by: David Ahern <dsahern@...il.com>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/