linux-kernel - Re: [PATCH] mm: bugfix: set current->reclaim_state to NULL while returning from kswapd()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1211051342240.5296@chino.kir.corp.google.com>
Date:	Mon, 5 Nov 2012 13:44:32 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	Aaditya Kumar <aaditya.kumar.30@...il.com>
cc:	LKML <linux-kernel@...r.kernel.org>, linux-mm@...ck.org,
	kosaki.motohiro@...fujitsu.com,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	KOSAKI Motohiro <kosaki.motohiro@...il.com>,
	Mel Gorman <mel@....ul.ie>, akpm@...ux-foundation.org,
	Minchan Kim <minchan.kim@...il.com>,
	takamori.yamaguchi@...sony.com, takuzo.ohara@...sony.com,
	amit.agarwal@...sony.com, tim.bird@...sony.com,
	frank.rowand@...sony.com, kan.iibuchi@...sony.com,
	aaditya.kumar@...sony.com
Subject: Re: [PATCH] mm: bugfix: set current->reclaim_state to NULL while
 returning from kswapd()

On Tue, 6 Nov 2012, Aaditya Kumar wrote:

> From: Takamori Yamaguchi <takamori.yamaguchi@...sony.com>
> 
> In kswapd(), set current->reclaim_state to NULL before returning, as
> current->reclaim_state holds reference to variable on kswapd()'s stack.
> 
> In rare cases, while returning from kswapd() during memory off lining,
> __free_slab() can access dangling pointer of current->reclaim_state.
> 

It's __free_slab() for slub and kmem_freepages() for slab.

> Signed-off-by: Takamori Yamaguchi <takamori.yamaguchi@...sony.com>
> Signed-off-by: Aaditya Kumar <aaditya.kumar@...sony.com>

Acked-by: David Rientjes <rientjes@...gle.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/