linux-kernel - Re: [PATCH V2 3/3] checkpatch: Emit an warning when floating point values are used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20121107085258.3a46f45f.akpm@linux-foundation.org>
Date:	Wed, 7 Nov 2012 08:52:58 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Joe Perches <joe@...ches.com>
Cc:	Andy Whitcroft <apw@...onical.com>,
	Adil Mujeeb <mujeeb.adil@...il.com>,
	Pavel Machek <pavel@....cz>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 3/3] checkpatch: Emit an warning when floating point
 values are used

On Wed, 07 Nov 2012 03:09:35 -0800 Joe Perches <joe@...ches.com> wrote:

> On Tue, 2012-11-06 at 15:36 -0800, Andrew Morton wrote:
> > On Thu,  1 Nov 2012 00:12:18 -0700
> > Joe Perches <joe@...ches.com> wrote:
> > > Linux kernel doesn't like floating point, say so. 
> []
> > > --- a/scripts/checkpatch.pl
> > > +++ b/scripts/checkpatch.pl
> > > @@ -2332,6 +2332,13 @@ sub process {
> > >  			     "do not add new typedefs\n" . $herecurr);
> > >  		}
> > >  
> > > +# check for floating point constants
> > > +
> > > +		if ($line =~ /\b$Float\b/) {
> > > +			WARN("KERNEL_FLOAT",
> > > +			     "Floating point is not supported in linux kernel source\n" . $herecurr);
> > > +		}
> > > +
> > >  # * goes on variable not on type
> > >  		# (char*[ const])
> > >  		while ($line =~ m{(\($NonptrType(\s*(?:$Modifier\b\s*|\*\s*)+)\))}g) {
> > 
> > The earlier review comments were not addressed.
> 
> You didn't read my response in the thread then.

There was no response afaict.  Not here, not on lkml.org?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/