linux-kernel - Re: [PATCH] pinctrl: Staticize pinconf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAP1dx+zMZe0rnmOEBpo4FYB_zskiB3x0BFjqM=NoqXS7XvOMxA@mail.gmail.com>
Date:	Wed, 7 Nov 2012 14:04:57 +0800
From:	Dong Aisheng <dong.aisheng@...aro.org>
To:	Axel Lin <axel.lin@...ics.com>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Simon Arlott <simon@...e.lp0.eu>,
	John Crispin <blogic@...nwrt.org>,
	Shawn Guo <shawn.guo@...aro.org>,
	Stephen Warren <swarren@...dotorg.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: Staticize pinconf_ops

On 7 November 2012 13:37, Axel Lin <axel.lin@...ics.com> wrote:
> They are not referenced outside respective driver.
>
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>
> Cc: Simon Arlott <simon@...e.lp0.eu>
> Cc: John Crispin <blogic@...nwrt.org>
> Cc: Dong Aisheng <dong.aisheng@...aro.org>
> Cc: Shawn Guo <shawn.guo@...aro.org>
> Cc: Stephen Warren <swarren@...dotorg.org>
> ---
>  drivers/pinctrl/pinctrl-at91.c    |    2 +-
>  drivers/pinctrl/pinctrl-bcm2835.c |    2 +-
>  drivers/pinctrl/pinctrl-falcon.c  |    2 +-
>  drivers/pinctrl/pinctrl-imx.c     |    2 +-

For imx,
Acked-by: Dong Aisheng <dong.aisheng@...aro.org>

Regards
Dong Aisheng

>  drivers/pinctrl/pinctrl-mxs.c     |    2 +-
>  drivers/pinctrl/pinctrl-tegra.c   |    2 +-
>  drivers/pinctrl/pinctrl-xway.c    |    2 +-
>  7 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
> index b9e2cbd..8490a55 100644
> --- a/drivers/pinctrl/pinctrl-at91.c
> +++ b/drivers/pinctrl/pinctrl-at91.c
> @@ -665,7 +665,7 @@ static void at91_pinconf_group_dbg_show(struct pinctrl_dev *pctldev,
>  {
>  }
>
> -struct pinconf_ops at91_pinconf_ops = {
> +static struct pinconf_ops at91_pinconf_ops = {
>         .pin_config_get                 = at91_pinconf_get,
>         .pin_config_set                 = at91_pinconf_set,
>         .pin_config_dbg_show            = at91_pinconf_dbg_show,
> diff --git a/drivers/pinctrl/pinctrl-bcm2835.c b/drivers/pinctrl/pinctrl-bcm2835.c
> index 7e9be18..9a963ed 100644
> --- a/drivers/pinctrl/pinctrl-bcm2835.c
> +++ b/drivers/pinctrl/pinctrl-bcm2835.c
> @@ -916,7 +916,7 @@ static int bcm2835_pinconf_set(struct pinctrl_dev *pctldev,
>         return 0;
>  }
>
> -struct pinconf_ops bcm2835_pinconf_ops = {
> +static struct pinconf_ops bcm2835_pinconf_ops = {
>         .pin_config_get = bcm2835_pinconf_get,
>         .pin_config_set = bcm2835_pinconf_set,
>  };
> diff --git a/drivers/pinctrl/pinctrl-falcon.c b/drivers/pinctrl/pinctrl-falcon.c
> index ee73059..8ed20e8 100644
> --- a/drivers/pinctrl/pinctrl-falcon.c
> +++ b/drivers/pinctrl/pinctrl-falcon.c
> @@ -322,7 +322,7 @@ static void falcon_pinconf_group_dbg_show(struct pinctrl_dev *pctrldev,
>  {
>  }
>
> -struct pinconf_ops falcon_pinconf_ops = {
> +static struct pinconf_ops falcon_pinconf_ops = {
>         .pin_config_get                 = falcon_pinconf_get,
>         .pin_config_set                 = falcon_pinconf_set,
>         .pin_config_group_get           = falcon_pinconf_group_get,
> diff --git a/drivers/pinctrl/pinctrl-imx.c b/drivers/pinctrl/pinctrl-imx.c
> index 63866d9..f3d2384 100644
> --- a/drivers/pinctrl/pinctrl-imx.c
> +++ b/drivers/pinctrl/pinctrl-imx.c
> @@ -397,7 +397,7 @@ static void imx_pinconf_group_dbg_show(struct pinctrl_dev *pctldev,
>         }
>  }
>
> -struct pinconf_ops imx_pinconf_ops = {
> +static struct pinconf_ops imx_pinconf_ops = {
>         .pin_config_get = imx_pinconf_get,
>         .pin_config_set = imx_pinconf_set,
>         .pin_config_dbg_show = imx_pinconf_dbg_show,
> diff --git a/drivers/pinctrl/pinctrl-mxs.c b/drivers/pinctrl/pinctrl-mxs.c
> index 4ba4636..3e7d4d6 100644
> --- a/drivers/pinctrl/pinctrl-mxs.c
> +++ b/drivers/pinctrl/pinctrl-mxs.c
> @@ -319,7 +319,7 @@ static void mxs_pinconf_group_dbg_show(struct pinctrl_dev *pctldev,
>                 seq_printf(s, "0x%lx", config);
>  }
>
> -struct pinconf_ops mxs_pinconf_ops = {
> +static struct pinconf_ops mxs_pinconf_ops = {
>         .pin_config_get = mxs_pinconf_get,
>         .pin_config_set = mxs_pinconf_set,
>         .pin_config_group_get = mxs_pinconf_group_get,
> diff --git a/drivers/pinctrl/pinctrl-tegra.c b/drivers/pinctrl/pinctrl-tegra.c
> index 7da0b37..f7fe91e 100644
> --- a/drivers/pinctrl/pinctrl-tegra.c
> +++ b/drivers/pinctrl/pinctrl-tegra.c
> @@ -660,7 +660,7 @@ static void tegra_pinconf_config_dbg_show(struct pinctrl_dev *pctldev,
>  }
>  #endif
>
> -struct pinconf_ops tegra_pinconf_ops = {
> +static struct pinconf_ops tegra_pinconf_ops = {
>         .pin_config_get = tegra_pinconf_get,
>         .pin_config_set = tegra_pinconf_set,
>         .pin_config_group_get = tegra_pinconf_group_get,
> diff --git a/drivers/pinctrl/pinctrl-xway.c b/drivers/pinctrl/pinctrl-xway.c
> index b9bcaec..ad90984 100644
> --- a/drivers/pinctrl/pinctrl-xway.c
> +++ b/drivers/pinctrl/pinctrl-xway.c
> @@ -522,7 +522,7 @@ static int xway_pinconf_set(struct pinctrl_dev *pctldev,
>         return 0;
>  }
>
> -struct pinconf_ops xway_pinconf_ops = {
> +static struct pinconf_ops xway_pinconf_ops = {
>         .pin_config_get = xway_pinconf_get,
>         .pin_config_set = xway_pinconf_set,
>  };
> --
> 1.7.9.5
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/