linux-kernel - Re: [PATCH 1/1] isdn: Make CONFIG_ISDN depend on CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20121107.185951.1536161042866737820.davem@davemloft.net>
Date:	Wed, 07 Nov 2012 18:59:51 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	lee.jones@...aro.org
Cc:	linux-kernel@...r.kernel.org, isdn@...ux-pingi.de,
	netdev@...r.kernel.org
Subject: Re: [PATCH 1/1] isdn: Make CONFIG_ISDN depend on CONFIG_NETDEVICES

From: Lee Jones <lee.jones@...aro.org>
Date: Wed,  7 Nov 2012 10:55:03 +0100

> It doesn't make much sense to enable ISDN services if you don't
> intend to connect to a network. Therefore insisting that ISDN
> depends on NETDEVICES seems logical. We can then remove any
> guards mentioning NETDEVICES inside all subordinate drivers.
> 
> This also has the nice side-effect of fixing the warning below
> when ISDN_I4L && !CONFIG_NETDEVICES at compile time.
> 
> This patch fixes:
> drivers/isdn/i4l/isdn_common.c: In function ‘isdn_ioctl’:
> drivers/isdn/i4l/isdn_common.c:1278:8: warning: unused variable ‘s’ [-Wunused-variable]
> 
> Cc: Karsten Keil <isdn@...ux-pingi.de>
> Cc: netdev@...r.kernel.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

Applied, thanks.