linux-kernel - Re: [PATCH 00/13] A simple hardware detector for latency as well as throughtput ver 0.10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121108160458.GC766@thunk.org>
Date:	Thu, 8 Nov 2012 11:04:58 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	Luming Yu <luming.yu@...il.com>
Cc:	arnd@...db.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/13] A simple hardware detector for latency as well as
 throughtput ver 0.10

On Sun, Nov 04, 2012 at 08:59:31PM -0500, Luming Yu wrote:
> Back to July of this year, I sent the first round of the tool.
> Now I've polished it a little bit.
> 
> The patch is the fist step to test some basic hardware functions like
> TSC to help people understand if there is any hardware latency as well
> as throughput problem exposed on bare metal or left behind by BIOS or
> interfered by SMI. Currently the patch tests TSC, CPU Frequency, and
> RDRAND, which is a new CPU instruction to get random number introudced
> in new CPU like Intel Ivy Bridge, in stop_machine context.

You are adding a new file, drivers/misc/hw_latency_test.c to the
kernel.  I don't think it makes sense to include the file, and then
follow it with 12 patches which modify the file.  You don't need to
"show your work" with the various bug fixes that has been made since
July.  I'd recommend collapsing all of the collected patches plus the
base file into a single commit.

Regards,

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/