linux-kernel - Re: [PATCH v2] loop: Limit the number of requests in the bio list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <x49k3tvrcci.fsf@segfault.boston.devel.redhat.com>
Date:	Thu, 08 Nov 2012 16:53:01 -0500
From:	Jeff Moyer <jmoyer@...hat.com>
To:	Lukas Czerner <lczerner@...hat.com>
Cc:	axboe@...nel.dk, dchinner@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] loop: Limit the number of requests in the bio list

Lukas Czerner <lczerner@...hat.com> writes:

> +	if (lo->lo_bio_count >= lo->lo_queue->nr_requests) {
> +		unsigned int nr;
> +		spin_unlock_irq(&lo->lo_lock);
> +		nr = lo->lo_queue->nr_requests - (lo->lo_queue->nr_requests/8);
> +		wait_event_interruptible(lo->lo_req_wait,
> +					 lo->lo_bio_count < nr);
> +		spin_lock_irq(&lo->lo_lock);
> +	}

So, blk_queue_make_request already initialized q->nr_congestion_on and
q->nr_congestion_off.  Is there a reason you didn't simply use
queue_congestion_on_threshold and queue_congestion_off_threshold?

Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/