lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 09 Nov 2012 16:25:28 -0500 (EST) From: David Miller <davem@...emloft.net> To: zheng.x.li@...cle.com Cc: netdev@...r.kernel.org, fubar@...ibm.com, andy@...yhouse.net, linux-kernel@...r.kernel.org, joe.jin@...cle.com Subject: Re: [PATCH] bonding: rlb mode of bond should not alter ARP replies originating via bridge From: Zheng Li <zheng.x.li@...cle.com> Date: Wed, 7 Nov 2012 11:23:00 +0800 > ARP traffic passing through a bridge and out via the bond (when the bond is a > port of the bridge) should not have its source MAC address adjusted by the > receive load balance code in rlb_arp_xmit. > > Signed-off-by: Zheng Li <zheng.x.li@...cle.com> Please format these change properly, this is not indented correctly at all: > + if (ether_addr_equal_64bits(arp->mac_src, > + tmp_slave->dev->dev_addr)) { > + memcpy(arp->mac_src, > + tx_slave->dev->dev_addr, > + ETH_ALEN); > + break; Arguments to functions should line up, always, with the first column after the openning parenthesis of the function call. If that makes the far right column of the line go too far past 80 columns, too bad. Make and use a helper function to perform this test in that case. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists