| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20121109.163012.719663130136182296.davem@davemloft.net> Date: Fri, 09 Nov 2012 16:30:12 -0500 (EST) From: David Miller <davem@...emloft.net> To: dwmw2@...radead.org Cc: krzysiek@...lesie.net, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, chas@....nrl.navy.mil Subject: Re: [PATCH v3 8/7] pppoatm: fix missing wakeup in pppoatm_send() From: David Woodhouse <dwmw2@...radead.org> Date: Wed, 07 Nov 2012 12:52:14 +0000 > Now that we can return zero from pppoatm_send() for reasons *other* than > the queue being full, that means we can't depend on a subsequent call to > pppoatm_pop() waking the queue, and we might leave it stalled > indefinitely. > > Fix this by immediately scheduling the wakeup tasklet. As documented > already elsewhere, the PPP channel's ->downl lock protects against the > wakeup happening too soon and effectively being missed. > > Signed-off-by: David Woodhouse <David.Woodhouse@...el.com> > ---- > Untested. > With this sorted, Acked-By: David Woodhouse <David.Woodhouse@...el.com< > to the other seven. Thanks. I don't know what to do with this patch because I don't have any context whatsoever. So I'm tossing it, please resubmit it when it's meant to be applied, and with some context. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists