linux-kernel - Re: [PATCH] regulator: core: Add locked version of regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50A28055.7040606@nvidia.com>
Date:	Tue, 13 Nov 2012 22:46:05 +0530
From:	Laxman Dewangan <ldewangan@...dia.com>
To:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
CC:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	"lrg@...com" <lrg@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] regulator: core: Add locked version of regulator_put
 to	avoid deadlock

On Tuesday 13 November 2012 10:00 PM, Charles Keepax wrote:
> When regulator_register fails and exits through the scrub path the
> regulator_put function was called whilst holding the
> regulator_list_mutex, which is also locked from regulator_put, causing
> deadlock.
>
> This patch adds a locked version of the regulator_put function which can
> be safely called whilst holding the mutex, replacing the aforementioned
> call.
>
> Signed-off-by: Charles Keepax<ckeepax@...nsource.wolfsonmicro.com>
> Cc: Laxman Dewangan<ldewangan@...dia.com>
> ---
>
> I hope this isn't bad etiquette but I took the liberaty of fixing up
> the patch as per the comments and taking into account the removal of
> my original patch. Apologies if this is not the done thing, do let
> me know if you would rather submit a version yourself but I
> thought best to address the issue and get a fix in.

This looks fine.
Acked-by: Laxman Dewangan <ldewangan@...dia.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/