linux-kernel - Re: [PATCH] regulator: core: Add locked version of regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121113232537.GA27212@opensource.wolfsonmicro.com>
Date:	Wed, 14 Nov 2012 08:25:56 +0900
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
Cc:	lrg@...com, ldewangan@...dia.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: core: Add locked version of regulator_put to
 avoid deadlock

On Tue, Nov 13, 2012 at 04:30:40PM +0000, Charles Keepax wrote:

> -void regulator_put(struct regulator *regulator)
> +static void __regulator_put_locked(struct regulator *regulator)

Please do follow the coding style of the rest of the code; nothing else
is using __ for private functions.

Please also clarify the changelog - you're not adding a new API here,
you're fiddling about with the internals.  Obviously regulator_put() is
always locked, you're just rearranging code inside the core here.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)