linux-kernel - Re: FW: [PATCH v2] mmc: sdhci: apply voltage range check only for non-fixed regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121114072855.GF7407@opensource.wolfsonmicro.com>
Date:	Wed, 14 Nov 2012 16:28:56 +0900
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Kevin Liu <keyuan.liu@...il.com>
Cc:	m.szyprowski@...sung.com, Chris Ball <cjb@...top.org>,
	linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
	kyungmin.park@...sung.com, lrg@...com,
	Philip Rakity <prakity@...dia.com>
Subject: Re: FW: [PATCH v2] mmc: sdhci: apply voltage range check only for
 non-fixed regulators

On Wed, Nov 14, 2012 at 03:11:37PM +0800, Kevin Liu wrote:

> -		ret = regulator_set_voltage(host->vqmmc, 3300000, 3300000);
> +		ret = regulator_set_voltage(host->vqmmc, 2700000, 3600000);

Should this be regulator_set_voltage_tol()?  Otherwise it'd be good to
explain where the numbers come from.

> +		ret = regulator_is_supported_voltage(host->vmmc, 1700000,
> +			1950000);

We should really add a regulator_is_supported_voltage_tol...  let me
just do that.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)