linux-kernel - Re: [PATCH V3 1/2] mfd: add TI TPS80031 mfd core driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121114024529.GN4415@opensource.wolfsonmicro.com>
Date:	Wed, 14 Nov 2012 11:45:31 +0900
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	"sameo@...ux.intel.com" <sameo@...ux.intel.com>,
	"lrg@...com" <lrg@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V3 1/2] mfd: add TI TPS80031 mfd core driver

On Tue, Nov 13, 2012 at 09:35:45PM -0500, Laxman Dewangan wrote:

> Yes, this is not a good idea, We will need support for wakeup
> without wakeup registers.
> Probably we need to add one more parameter, wake enable to control
> without wake_base.

This does not seem sensible.  Why would this be optional if it is
useful?  In any case, what you're doing in the driver here is clearly
not the way forward.

> >>There is 2 sets of registers which need to be configure, MASK and
> >>LINE enable.
> >So what does the second one do?

> The MASK register used for updating status register when interrupt
> occurs and LINE register used to pass the status to actual interrupt
> line.

So this sounds like the LINE register is actually the mask register
which is the opposite way around...  please describe this stuff in the
comments anyway.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)