linux-kernel - Re: [PATCH 2/4] staging/serqt_usb2: refactor qt_read_bulk_callback() in serqt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121115204333.GJ11566@mwanda>
Date:	Thu, 15 Nov 2012 23:43:34 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	YAMANE Toshiaki <yamanetoshi@...il.com>
Cc:	devel@...verdev.osuosl.org,
	Mauro Carvalho Chehab <mchehab@...hat.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	linux-kernel@...r.kernel.org,
	Alan Stern <stern@...land.harvard.edu>
Subject: Re: [PATCH 2/4] staging/serqt_usb2: refactor qt_read_bulk_callback()
 in serqt_usb2.c


Btw:
> +             dev_dbg(&port->dev, "Line status status.\n");
                                     ^^^^^^^^^^^^^^^^^^^
These kind of debug statements which just tell which function is
being called can be deleted.  The function tracer already provides
that information.

> +             fn = ProcessLineStatus;
> +     } else {
> +             dev_dbg(&port->dev, "Modem status status.\n");
> +             fn = ProcessModemStatus;

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/