linux-kernel - Re: [PATCH 1/8] staging: line6: wrap >80 char lines in capture.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 15 Nov 2012 22:03:27 +0100
From:	Markus Grabner <grabner@....tugraz.at>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Stefan Hajnoczi <stefanha@...il.com>, devel@...verdev.osuosl.org,
	line6linux-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, Daniel Mack <zonque@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 1/8] staging: line6: wrap >80 char lines in capture.c

Am Mittwoch, 14. November 2012, 17:33:05 schrieb Dan Carpenter:
> On Sun, Nov 11, 2012 at 01:24:39PM +0100, Stefan Hajnoczi wrote:
> > Signed-off-by: Stefan Hajnoczi <stefanha@...il.com>
> > ---
> > 
> >  drivers/staging/line6/capture.c | 13 ++++++++-----
> >  1 file changed, 8 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/staging/line6/capture.c
> > b/drivers/staging/line6/capture.c index c85c5b6..389c41f 100644
> > --- a/drivers/staging/line6/capture.c
> > +++ b/drivers/staging/line6/capture.c
> > @@ -256,8 +256,8 @@ static void audio_in_callback(struct urb *urb)
> > 
> >  #ifdef CONFIG_LINE6_USB_IMPULSE_RESPONSE
> >  
> >  		if (!(line6pcm->flags & LINE6_BITS_PCM_IMPULSE))
> >  
> >  #endif
> > 
> > -			if (test_bit(LINE6_INDEX_PCM_ALSA_CAPTURE_STREAM, &line6pcm-
>flags)
> > -			    && (fsize > 0))
> > +			if (test_bit(LINE6_INDEX_PCM_ALSA_CAPTURE_STREAM,
> 
> The reason this is hitting the 80 character limit is because
> "LINE6_INDEX_PCM_ALSA_CAPTURE_STREAM" is 35 characters long.  It
> isn't even clear from the name what it holds.  It's just a very crap
> name.
Please refer to the file pcm.h for a detailed documentation of this and 
similar names (in fact, the documentation explains the LINE6_BIT_PCM_* names 
instead, but I bevlieve the correspondence is obvious). It's hard to define a 
shorter name which is at the same time descriptive, consistent, and not to be 
confused with related names.

Should such documentation be moved to a separate file (e.g., 
"Documentation/sound/alsa/line6usb.txt")?

	Kind regards,
		Markus

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/