linux-kernel - Re: [PATCH RESEND] regmap: introduce tables for readable/writeable/volatile/precious checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121116011904.GH4387@opensource.wolfsonmicro.com>
Date:	Fri, 16 Nov 2012 10:19:07 +0900
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	ciminaghi@...dd.com
Cc:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND] regmap: introduce tables for
 readable/writeable/volatile/precious checks

On Thu, Nov 15, 2012 at 01:46:52PM +0100, ciminaghi@...dd.com wrote:

> I haven't seen any reply up to now, so I'm just resending the original patch
> (see https://lkml.org/lkml/2012/10/25/224).
> I just applied it to today's next and did a quick re-test.

The fact that you don't send a real name in your patch submission mails
might be an issue here - I suspect you've fallen foul of spam filtering,
either automatic or human, there's no sign of this in my pending queue.

> +static inline bool _reg_in_ranges(unsigned int reg,
> +				  const struct regmap_range *ranges,
> +				  unsigned int nranges)
> +{
> +	const struct regmap_range *r;
> +	int i;
> +
> +	for (i = 0, r = ranges; i < nranges; i++, r++)
> +		if (_reg_in_range(reg, r))
> +			return true;
> +	return false;
> +}

It would be better to make this an externally visible function (perhaps
just move it into the header with a regmap on the front of the name) so
that drivers can use this as part of the implementation of more complex
checks.  Otherwise this looks fine.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)