linux-kernel - Re: [PATCH 2/3] pwm: lpc32xx - Properly disable the clock on device remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121116201655.GA24790@avionic-0098.mockup.avionic-design.de>
Date:	Fri, 16 Nov 2012 21:16:55 +0100
From:	Thierry Reding <thierry.reding@...onic-design.de>
To:	Alban Bedel <alban.bedel@...onic-design.de>
Cc:	linux-kernel@...r.kernel.org, Roland Stigge <stigge@...com.de>,
	Alexandre Pereira da Silva <aletes.xgr@...il.com>
Subject: Re: [PATCH 2/3] pwm: lpc32xx - Properly disable the clock on device
 remove

On Wed, Nov 14, 2012 at 12:58:14PM +0100, Alban Bedel wrote:
[...]
>  static int __devexit lpc32xx_pwm_remove(struct platform_device *pdev)
>  {
>  	struct lpc32xx_pwm_chip *lpc32xx = platform_get_drvdata(pdev);
> +	int i;

This should rather be unsigned int since pwm_chip.npwm is unsigned as
well.

> +
> +	for (i = 0 ; i < lpc32xx->chip.npwm ; i += 1)

No space before ';' and "i++" please.

Thierry

Content of type "application/pgp-signature" skipped