linux-kernel - Re: removal of sysfs wext extension broke on F16

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1353098379.9490.22.camel@jlt4.sipsolutions.net>
Date:	Fri, 16 Nov 2012 21:39:39 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Dave Airlie <airlied@...il.com>,
	John Linville <linville@...driver.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Bill Nottingham <notting@...hat.com>,
	linux-wireless@...r.kernel.org
Subject: Re: removal of sysfs wext extension broke on F16

On Fri, 2012-11-16 at 21:36 +0100, Johannes Berg wrote:
> On Fri, 2012-11-16 at 21:35 +0100, Johannes Berg wrote:
> > On Fri, 2012-11-16 at 10:20 -0800, Linus Torvalds wrote:
> > > On Tue, Nov 13, 2012 at 12:27 AM, Johannes Berg
> > > <johannes@...solutions.net> wrote:
> > > >
> > > > Should I revert it and send it in my next pull request?
> > > 
> > > Please do. Or perhaps we could just add the directory back, without
> > > the actual entries, if that is sufficient..
> > 
> > Yeah, that does seem to be sufficient, I'll queue up the patch below.
> 
> Err, no, wishful thinking. I need a *little* bit more for sysfs to work.

This works, sorry about that.

>From 38c1a01cf10c6e4049b4ffbd4a6af655df2a46e1 Mon Sep 17 00:00:00 2001
From: Johannes Berg <johannes.berg@...el.com>
Date: Fri, 16 Nov 2012 20:46:19 +0100
Subject: [PATCH] wireless: add back sysfs directory

commit 35b2a113cb0298d4f9a1263338b456094a414057 broke (at least)
Fedora's networking scripts, they check for the existence of the
wireless directory. As the files aren't used, add the directory
back and not the files. Also do it for both drivers based on the
old wireless extensions and cfg80211, regardless of whether the
compat code for wext is built into cfg80211 or not.

Cc: stable@...r.kernel.org [3.6]
Reported-by: Dave Airlie <airlied@...il.com>
Reported-by: Bill Nottingham <notting@...hat.com>
Signed-off-by: Johannes Berg <johannes.berg@...el.com>
---
 net/core/net-sysfs.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
index bcf02f6..017a8ba 100644
--- a/net/core/net-sysfs.c
+++ b/net/core/net-sysfs.c
@@ -429,6 +429,17 @@ static struct attribute_group netstat_group = {
 	.name  = "statistics",
 	.attrs  = netstat_attrs,
 };
+
+#if IS_ENABLED(CONFIG_WIRELESS_EXT) || IS_ENABLED(CONFIG_CFG80211)
+static struct attribute *wireless_attrs[] = {
+	NULL
+};
+
+static struct attribute_group wireless_group = {
+	.name = "wireless",
+	.attrs = wireless_attrs,
+};
+#endif
 #endif /* CONFIG_SYSFS */
 
 #ifdef CONFIG_RPS
@@ -1409,6 +1420,15 @@ int netdev_register_kobject(struct net_device *net)
 		groups++;
 
 	*groups++ = &netstat_group;
+
+#if IS_ENABLED(CONFIG_WIRELESS_EXT) || IS_ENABLED(CONFIG_CFG80211)
+	if (net->ieee80211_ptr)
+		*groups++ = &wireless_group;
+#if IS_ENABLED(CONFIG_WIRELESS_EXT)
+	else if (net->wireless_handlers)
+		*groups++ = &wireless_group;
+#endif
+#endif
 #endif /* CONFIG_SYSFS */
 
 	error = device_add(dev);
-- 
1.8.0



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/