linux-kernel - Re: removal of sysfs wext extension broke on F16

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1211162330090.19580@aurora.sdinet.de>
Date:	Fri, 16 Nov 2012 23:32:32 +0100 (CET)
From:	Sven-Haegar Koch <haegar@...net.de>
To:	Johannes Berg <johannes@...solutions.net>
cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Dave Airlie <airlied@...il.com>,
	John Linville <linville@...driver.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Bill Nottingham <notting@...hat.com>,
	linux-wireless@...r.kernel.org
Subject: Re: removal of sysfs wext extension broke on F16

On Fri, 16 Nov 2012, Johannes Berg wrote:

> On Fri, 2012-11-16 at 21:36 +0100, Johannes Berg wrote:
> > On Fri, 2012-11-16 at 21:35 +0100, Johannes Berg wrote:
> > > On Fri, 2012-11-16 at 10:20 -0800, Linus Torvalds wrote:
> > > > On Tue, Nov 13, 2012 at 12:27 AM, Johannes Berg
> > > > <johannes@...solutions.net> wrote:
> > > > >
> > > > > Should I revert it and send it in my next pull request?
> > > > 
> > > > Please do. Or perhaps we could just add the directory back, without
> > > > the actual entries, if that is sufficient..
> > > 
> > > Yeah, that does seem to be sufficient, I'll queue up the patch below.
> > 
> > Err, no, wishful thinking. I need a *little* bit more for sysfs to work.
> 
> This works, sorry about that.

> +#if IS_ENABLED(CONFIG_WIRELESS_EXT) || IS_ENABLED(CONFIG_CFG80211)
> +static struct attribute *wireless_attrs[] = {
> +	NULL
> +};
> +
> +static struct attribute_group wireless_group = {
> +	.name = "wireless",
> +	.attrs = wireless_attrs,
> +};
> +#endif
>  #endif /* CONFIG_SYSFS */
>  

How about a small comment in the source why it is there? I suppose 
otherwise in a year or two someone will find it, see "WTF? Useless 
empty directory?" and try to remove it again...

c'ya
sven-haegar

-- 
Three may keep a secret, if two of them are dead.
- Ben F.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/