lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 18 Nov 2012 17:43:07 +0200 From: Vladimir Kondratiev <vkondrat@....qualcomm.com> To: Joe Perches <joe@...ches.com> Cc: "John W . Linville" <linville@...driver.com>, Johannes Berg <johannes@...solutions.net>, Andrew Morton <akpm@...ux-foundation.org>, linux-wireless@...r.kernel.org, "Luis R . Rodriguez" <rodrigue@....qualcomm.com>, Jason Baron <jbaron@...hat.com>, Jim Cromie <jim.cromie@...il.com>, Greg KH <gregkh@...uxfoundation.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [RFC] dynamic_debug: introduce debug_hex_dump() On Sunday, November 18, 2012 06:38:51 AM Joe Perches wrote: > Another option could be testing __builtin_constant_p(prefix) You mean something like below? Yes, it will work as well. Pro: don't need to change existing code (drop [PATCH 2/2] dynamic_debug: use constant format in print_hex_dump_bytes()) Cons: format in dynamic metadata will be useless What looks better? --- #define dynamic_hex_dump(prefix_str, prefix_type, rowsize, \ groupsize, buf, len, ascii) \ do { \ DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, \ __builtin_constant_p(prefix_str) ? prefix_str : "hexdump");\ if (unlikely(descriptor.flags & _DPRINTK_FLAGS_PRINT)) \ print_hex_dump(KERN_DEBUG, prefix_str, \ prefix_type, rowsize, groupsize, \ buf, len, ascii); \ } while (0) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists