linux-kernel - Re: [PATCH RESEND] max17042: missing assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121118230345.GB29066@lizard.sbx05977.paloaca.wayport.net>
Date:	Sun, 18 Nov 2012 15:03:46 -0800
From:	Anton Vorontsov <anton.vorontsov@...aro.org>
To:	"Pallala, Ramakrishna" <ramakrishna.pallala@...el.com>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RESEND] max17042: missing assignment

On Thu, Oct 25, 2012 at 02:28:03PM +0000, Pallala, Ramakrishna wrote:
> 
> Thanks Alan.
> 
> > The second error check is unreachable because the lock function isn't assigned
> > to ret
> > 
> > Signed-off-by: Alan Cox <alan@...ux.intel.com>
> Acked-by: Ramakrishna Pallala <ramakrishna.pallala@...el.com>

For some reason I don't have the original patch in my mailbox. I wonder if
I have not been Cc'ed on this one or it got lost...

Anyway, I reconstructed it by hand and applied, thanks a lot!

Anton.

> > ---
> > 
> >  drivers/power/max17042_battery.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/power/max17042_battery.c
> > b/drivers/power/max17042_battery.c
> > index 74abc6c..73b432d 100644
> > --- a/drivers/power/max17042_battery.c
> > +++ b/drivers/power/max17042_battery.c
> > @@ -572,7 +572,7 @@ static int max17042_init_chip(struct max17042_chip
> > *chip)
> >  			__func__);
> >  		return -EIO;
> >  	}
> > -	max17042_verify_model_lock(chip);
> > +	ret = max17042_verify_model_lock(chip);
> >  	if (ret) {
> >  		dev_err(&chip->client->dev, "%s lock verify failed\n",
> >  			__func__);
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/