linux-kernel - RE: [PATCH RESEND] max17042: missing assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D854C92F57B1B347B57E531E78D05EAD24510D25@BGSMSX102.gar.corp.intel.com>
Date:	Thu, 25 Oct 2012 14:28:03 +0000
From:	"Pallala, Ramakrishna" <ramakrishna.pallala@...el.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	"Anton Vorontsov (cbouatmailru@...il.com)" <cbouatmailru@...il.com>
Subject: RE: [PATCH RESEND] max17042: missing assignment


Thanks Alan.

> The second error check is unreachable because the lock function isn't assigned
> to ret
> 
> Signed-off-by: Alan Cox <alan@...ux.intel.com>
Acked-by: Ramakrishna Pallala <ramakrishna.pallala@...el.com>

> ---
> 
>  drivers/power/max17042_battery.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/max17042_battery.c
> b/drivers/power/max17042_battery.c
> index 74abc6c..73b432d 100644
> --- a/drivers/power/max17042_battery.c
> +++ b/drivers/power/max17042_battery.c
> @@ -572,7 +572,7 @@ static int max17042_init_chip(struct max17042_chip
> *chip)
>  			__func__);
>  		return -EIO;
>  	}
> -	max17042_verify_model_lock(chip);
> +	ret = max17042_verify_model_lock(chip);
>  	if (ret) {
>  		dev_err(&chip->client->dev, "%s lock verify failed\n",
>  			__func__);