linux-kernel - Re: [PATCH v3 7/9] pstore: make sure pstore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121118024052.GA12833@lizard.sbx05977.paloaca.wayport.net>
Date:	Sat, 17 Nov 2012 18:40:53 -0800
From:	Anton Vorontsov <cbouatmailru@...il.com>
To:	dragos.tatulea@...el.com
Cc:	ccross@...roid.com, keescook@...omium.org, tony.luck@...el.com,
	linux-kernel@...r.kernel.org, adrian.hunter@...el.com,
	octavian.purdila@...el.com
Subject: Re: [PATCH v3 7/9] pstore: make sure pstore_write exists on flush
 error

On Thu, Oct 18, 2012 at 02:06:05PM +0300, dragos.tatulea@...el.com wrote:
> From: Dragos Tatulea <dragos.tatulea@...el.com>
> 
> Return error if flushing to backend failed.

I think you can easily fold this into 'pstore: add support for external
writers'.

Thanks.

> Signed-off-by: Dragos Tatulea <dragos.tatulea@...el.com>
> ---
>  fs/pstore/platform.c |    8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c
> index 3a4c38f..25f59ed 100644
> --- a/fs/pstore/platform.c
> +++ b/fs/pstore/platform.c
> @@ -445,7 +445,7 @@ void pstore_del_timer(void)
>  int pstore_write(enum pstore_type_id type, const char *buf, size_t size)
>  {
>  	size_t len;
> -	int err = 0, err2;
> +	int err = 0;
>  
>  	if (!psinfo)
>  		return -ENODEV;
> @@ -461,16 +461,14 @@ int pstore_write(enum pstore_type_id type, const char *buf, size_t size)
>  		psinfo->ext_part = 1;
>  	}
>  
> -	while (size) {
> +	while (size && !err) {
>  		len = min(size, psinfo->bufsize - psinfo->ext_len);
>  		memcpy(psinfo->buf + psinfo->ext_len, buf, len);
>  		psinfo->ext_len += len;
>  		buf += len;
>  		size -= len;
>  		if (psinfo->ext_len == psinfo->bufsize) {
> -			err2 = pstore_ext_flush();
> -			if (err2 && !err)
> -				err = err2;
> +			err = pstore_ext_flush();
>  		}
>  	}
>  
> -- 
> 1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/