linux-kernel - Re: [PATCH v3 8/9] pstore: max out console log level during sysfs dump switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121118024412.GB12833@lizard.sbx05977.paloaca.wayport.net>
Date:	Sat, 17 Nov 2012 18:44:12 -0800
From:	Anton Vorontsov <cbouatmailru@...il.com>
To:	dragos.tatulea@...el.com
Cc:	ccross@...roid.com, keescook@...omium.org, tony.luck@...el.com,
	linux-kernel@...r.kernel.org, adrian.hunter@...el.com,
	octavian.purdila@...el.com
Subject: Re: [PATCH v3 8/9] pstore: max out console log level during sysfs
 dump switch

On Thu, Oct 18, 2012 at 02:06:06PM +0300, dragos.tatulea@...el.com wrote:
> From: Dragos Tatulea <dragos.tatulea@...el.com>
> 
> Otherwise we might miss out on some pstore dumpers that use
> printks below current log level.

If anything, this should be folded into 'pstore: add debugfs support for
causing dumps and panics'. But I'm not sure about the debugfs stuff
anyway.

> Signed-off-by: Dragos Tatulea <dragos.tatulea@...el.com>
> ---
>  fs/pstore/platform.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c
> index 25f59ed..e3ad13e 100644
> --- a/fs/pstore/platform.c
> +++ b/fs/pstore/platform.c
> @@ -267,6 +267,7 @@ static DEFINE_SPINLOCK(dbg_lock);
>  static int dbg_dump(void *data, u64 val)
>  {
>  	unsigned long flags;
> +	int saved_loglevel;
>  
>  	switch (val) {
>  	case KMSG_DUMP_PANIC:
> @@ -276,7 +277,10 @@ static int dbg_dump(void *data, u64 val)
>  	case KMSG_DUMP_HALT:
>  	case KMSG_DUMP_POWEROFF:
>  		spin_lock_irqsave(&dbg_lock, flags);
> +		saved_loglevel = console_loglevel;
> +		console_loglevel =  15;
>  		kmsg_dump(val);
> +		console_loglevel = saved_loglevel;
>  		spin_unlock_irqrestore(&dbg_lock, flags);
>  		return 0;
>  	}
> -- 
> 1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/