linux-kernel - Re: [PATCH 2/2] input: Cypress PS/2 Trackpad link into psmouse-base

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121119234801.GB21922@core.coreip.homeip.net>
Date:	Mon, 19 Nov 2012 15:48:01 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Kamal Mostafa <kamal@...onical.com>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	Henrik Rydberg <rydberg@...omail.se>,
	David Solda <dso@...ress.com>,
	Troy Abercrombia <ta@...ress.com>,
	Cypress Semiconductor Corporation <customercare@...ress.com>,
	Kyle Fazzari <git@...tus.e4ward.com>,
	Mario Limonciello <mario_limonciello@...l.com>,
	Tim Gardner <tim.gardner@...onical.com>,
	Herton Krzesinski <herton.krzesinski@...onical.com>
Subject: Re: [PATCH 2/2] input: Cypress PS/2 Trackpad link into psmouse-base

Hi Kamal,

On Mon, Nov 19, 2012 at 03:30:37PM -0800, Kamal Mostafa wrote:
> @@ -321,6 +323,13 @@ static irqreturn_t psmouse_interrupt(struct serio *serio,
>  	if (psmouse->state <= PSMOUSE_RESYNCING)
>  		goto out;
>  
> +	/* For Cypress Trackpad to read some special data more than 6 bytes. */
> +	if (psmouse->state == PSMOUSE_CMD_CYTP) {
> +		psmouse->packet[psmouse->pktcnt++] = data;
> +		wake_up(&psmouse->ps2dev.wait);
> +		goto out;
> +	}

Instead of doing this have you tried extending size of cmdbuf in ps2dev
structure to 8?

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/