linux-kernel - Re: [PATCH 2/2] input: Cypress PS/2 Trackpad link into psmouse-base

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1353446929.28318.43.camel@fourier>
Date:	Tue, 20 Nov 2012 13:28:49 -0800
From:	Kamal Mostafa <kamal@...onical.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	Henrik Rydberg <rydberg@...omail.se>,
	David Solda <dso@...ress.com>,
	Troy Abercrombia <ta@...ress.com>,
	Cypress Semiconductor Corporation <customercare@...ress.com>,
	Kyle Fazzari <git@...tus.e4ward.com>,
	Mario Limonciello <mario_limonciello@...l.com>,
	Tim Gardner <tim.gardner@...onical.com>,
	Herton Krzesinski <herton.krzesinski@...onical.com>,
	Dudley Du <dudl@...ress.com>
Subject: Re: [PATCH 2/2] input: Cypress PS/2 Trackpad link into psmouse-base

On Mon, 2012-11-19 at 15:48 -0800, Dmitry Torokhov wrote:
> Hi Kamal,
> 
> On Mon, Nov 19, 2012 at 03:30:37PM -0800, Kamal Mostafa wrote:
> > @@ -321,6 +323,13 @@ static irqreturn_t psmouse_interrupt(struct serio *serio,
> >  	if (psmouse->state <= PSMOUSE_RESYNCING)
> >  		goto out;
> >  
> > +	/* For Cypress Trackpad to read some special data more than 6 bytes. */
> > +	if (psmouse->state == PSMOUSE_CMD_CYTP) {
> > +		psmouse->packet[psmouse->pktcnt++] = data;
> > +		wake_up(&psmouse->ps2dev.wait);
> > +		goto out;
> > +	}
> 
> Instead of doing this have you tried extending size of cmdbuf in ps2dev
> structure to 8?
> 

Thanks for suggesting this Dmitry.  I have now done that (and modified
cypress_ps2.c to set psmouse->state to the common PSMOUSE_CMD_MODE
instead).  This makes the psmouse-base linkage entirely clean, I
think...

And it *almost* works!  (Multitouch no longer works after suspend now).

Please see the forthcoming [PATCH v2] set, and thanks again for your
help.

 -Kamal


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/