| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1353386347.19552.1.camel@phoenix> Date: Tue, 20 Nov 2012 12:39:07 +0800 From: Axel Lin <axel.lin@...ics.com> To: Mark Brown <broonie@...nsource.wolfsonmicro.com> Cc: David Dajun Chen <dchen@...semi.com>, Ashish Jangam <ashish.jangam@...tcummins.com>, Liam Girdwood <lrg@...com>, linux-kernel@...r.kernel.org Subject: [PATCH RFT] regulator: da9055: Fix return wrong selector in da9055_regulator_get_voltage_sel We do "selector += info->volt.v_offset" in da9055_regulator_set_voltage_bits() to take care of voltage range that does not start with 0 offset. Thus in da9055_regulator_get_voltage_sel() we should do corresponding "sel -= volt.v_offset" before returning selector. Otherwise, we pass wrong selector for list_voltage callback. Signed-off-by: Axel Lin <axel.lin@...ics.com> --- drivers/regulator/da9055-regulator.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/regulator/da9055-regulator.c b/drivers/regulator/da9055-regulator.c index 79c5665..dbcb43d 100644 --- a/drivers/regulator/da9055-regulator.c +++ b/drivers/regulator/da9055-regulator.c @@ -232,10 +232,9 @@ static int da9055_regulator_get_voltage_sel(struct regulator_dev *rdev) return ret; sel = (ret & volt.v_mask); - if (sel <= volt.v_offset) - return 0; - else - return sel; + sel -= volt.v_offset; + + return sel; } static int da9055_regulator_set_voltage_bits(struct regulator_dev *rdev, -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists