linux-kernel - Re: [PATCH RFT] regulator: da9055: Fix return wrong selector in da9055_regulator_get_voltage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121120045119.GG4483@opensource.wolfsonmicro.com>
Date:	Tue, 20 Nov 2012 13:51:21 +0900
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Axel Lin <axel.lin@...ics.com>
Cc:	David Dajun Chen <dchen@...semi.com>,
	Ashish Jangam <ashish.jangam@...tcummins.com>,
	Liam Girdwood <lrg@...com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFT] regulator: da9055: Fix return wrong selector in
 da9055_regulator_get_voltage_sel

On Tue, Nov 20, 2012 at 12:39:07PM +0800, Axel Lin wrote:
> We do "selector += info->volt.v_offset" in da9055_regulator_set_voltage_bits()
> to take care of voltage range that does not start with 0 offset.
> Thus in da9055_regulator_get_voltage_sel() we should do corresponding
> "sel -= volt.v_offset" before returning selector.
> Otherwise, we pass wrong selector for list_voltage callback.

No, we should just be using raw register values as the selectors and
fixing this in list_voltage() by returning 0 for invalid selectors.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)