linux-kernel - Re: [PATCH] [firmware_class] Fix compile with no builtin firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121120181203.GA7922@shaftnet.org>
Date:	Tue, 20 Nov 2012 13:12:03 -0500
From:	Solomon Peachy <pizza@...ftnet.org>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	Ming Lei <tom.leiming@...il.com>, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH] [firmware_class] Fix compile with no builtin firmware

On Tue, Nov 20, 2012 at 08:33:09AM -0800, Greg KH wrote:
> > The corresponding .config is attached.  Note that it is for a uClinux 
> > 3.3.0-uc0 kernel.
> 
> Lots of things have changed in the firmware code since 3.3.0, can you
> retest this on the 3.7-rc6 tree?

Not easily; My employer is contracted to do some driver porting and 
we're stuck with the kernel the client provided.  However, the patch is 
still relevant for upstream, because the underlying problem still 
exists:

 * The #ifdef wraps code that pertains solely to built-in firmware, (ie 
   CONFIG_FIRMWARE_IN_KERNEL) and has an #else path for when it's disabled.
 * There is no point in a CONFIG_FW_LOADER test inside firmware_class.c 
   when the file isn't even compiled unless CONFIG_FW_LOADER is defined.

Perhaps the compile problem is solved in newer kernels (by always 
generating an empty builtin firmware list?) but the #ifdef is still 
incorrect.

> Also, when sending patches, please cc: the proper maintainers (the
> scripts/get_maintainers.pl tool can help you with that.)

Ooops, sorry.  I'll double-check that next time.

 - Solomon
-- 
Solomon Peachy        		       pizza at shaftnet dot org	 
Melbourne, FL                          ^^ (mail/jabber/gtalk) ^^
Quidquid latine dictum sit, altum viditur.

Content of type "application/pgp-signature" skipped