linux-kernel - Re: [RFC PATCH] mm: trace filemap add and del

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87k3tf5jcc.fsf@free.fr>
Date:	Wed, 21 Nov 2012 11:41:23 +0100
From:	Robert Jarzmik <robert.jarzmik@...e.fr>
To:	Hugh Dickins <hughd@...gle.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] mm: trace filemap add and del

Hugh Dickins <hughd@...gle.com> writes:

> On Thu, 8 Nov 2012, Robert Jarzmik wrote:
>> --- a/mm/filemap.c
>> +++ b/mm/filemap.c
>> @@ -467,6 +471,7 @@ int add_to_page_cache_locked(struct page *page, struct address_space *mapping,
>>  		} else {
>>  			page->mapping = NULL;
>>  			/* Leave page->index set: truncation relies upon it */
>> +			trace_mm_filemap_add_to_page_cache(page);
>>  			spin_unlock_irq(&mapping->tree_lock);
>>  			mem_cgroup_uncharge_cache_page(page);
>>  			page_cache_release(page);
>
> I doubt if you really want your tracepoint sited just in this error path.

Urghh ... a git rebase mystified me.
In my original code, that tracepoint was 5 lines above, before the previous
spin_unlock_irq(), in the if branch, not the else branch.

Well spotted, I'll fix that for patch V2.

Cheers.

-- 
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/