lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 23 Nov 2012 09:41:32 +0000 From: Grant Likely <grant.likely@...retlab.ca> To: Viresh Kumar <viresh.kumar@...aro.org>, sameo@...ux.intel.com Cc: Viresh Kumar <viresh.kumar@...aro.org>, devicetree-discuss@...ts.ozlabs.org, spear-devel@...t.st.com, linux-kernel@...r.kernel.org, lee.jones@...aro.org Subject: Re: [PATCH V3 3/3] mfd: stmpe: Update DT support in stmpe driver On Fri, 23 Nov 2012 00:26:20 +0530, Viresh Kumar <viresh.kumar@...aro.org> wrote: > From: Vipul Kumar Samar <vipulkumar.samar@...com> > > This patch extends existing DT support for stmpe devices. This updates: > - DT support from stmpe SPI and I2C drivers > - missing header files in stmpe.c > - stmpe_of_probe() with pwm, rotator and new bindings. > - Bindings are updated in binding document. > > Signed-off-by: Vipul Kumar Samar <vipulkumar.samar@...com> > Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org> > --- > V2->V3: > ------ > - Removed sub-modules DT bindings from this patch > - Retain original work done by Lee Jones > > Documentation/devicetree/bindings/mfd/stmpe.txt | 12 ++++++++---- > drivers/mfd/stmpe-i2c.c | 15 +++++++++++++++ > drivers/mfd/stmpe-spi.c | 15 +++++++++++++++ > drivers/mfd/stmpe.c | 21 +++++++++++++++------ > 4 files changed, 53 insertions(+), 10 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/stmpe.txt b/Documentation/devicetree/bindings/mfd/stmpe.txt > index 8f0aeda..8f65c8d 100644 > --- a/Documentation/devicetree/bindings/mfd/stmpe.txt > +++ b/Documentation/devicetree/bindings/mfd/stmpe.txt > @@ -1,13 +1,17 @@ > -* STMPE Multi-Functional Device > +* ST Microelectronics STMPE Multi-Functional Device > + > +STMPE is an MFD device which may expose following inbuilt devices: gpio, keypad, > +touchscreen, adc, pwm, rotator. > > Required properties: > - - compatible : "st,stmpe[811|1601|2401|2403]" > - - reg : I2C address of the device > + - compatible : "st,stmpe[610|801|811|1601|2401|2403]" > + - reg : I2C/SPI address of the device > > Optional properties: > - interrupts : The interrupt outputs from the controller > - - interrupt-controller : Marks the device node as an interrupt controller > - interrupt-parent : Specifies which IRQ controller we're connected to > + - irq-trigger : IRQ trigger to use for the interrupt to the host > + - irq-invert-polarity : bool, IRQ line is connected with reversed polarity This looks odd. Normally the interrupt polarity should be encoded in the irq specifier flags field. g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists