linux-kernel - RE: [PATCH 1/1] TPM: STMicroelectronics ST33 I2C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <35286B1AE75A7C47BFF0870081A31B4B3A9B365A74@SAFEX1MAIL4.st.com>
Date:	Mon, 26 Nov 2012 17:03:45 +0100
From:	Mathias LEBLANC <Mathias.LEBLANC@...com>
To:	Kent Yoder <key@...ux.vnet.ibm.com>
Cc:	Rajiv Andrade <mail@...jiv.net>,
	Marcel Selhorst <tpmdd@...horst.net>,
	Sirrix AG <tpmdd@...rix.com>,
	"tpmdd-devel@...ts.sourceforge.net" 
	<tpmdd-devel@...ts.sourceforge.net>,
	Debora Velarde <debora@...ux.vnet.ibm.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Jean-Luc BLANC <jean-luc.blanc@...com>
Subject: RE: [PATCH 1/1] TPM: STMicroelectronics ST33 I2C

Hi Kent,
Thanks a lot, if you see other changes to make in  the driver, do not hesitate.
NB: I will not be available on Thursday and Friday in the coming weeks

-----Original Message-----
From: Kent Yoder [mailto:key@...ux.vnet.ibm.com] 
Sent: 26 November, 2012 16:52
To: Mathias LEBLANC
Cc: Rajiv Andrade; Marcel Selhorst; Sirrix AG; tpmdd-devel@...ts.sourceforge.net; Debora Velarde; linux-kernel@...r.kernel.org; Jean-Luc BLANC
Subject: Re: [PATCH 1/1] TPM: STMicroelectronics ST33 I2C

On Tue, Nov 20, 2012 at 09:26:40AM +0100, Mathias LEBLANC wrote:
> Hello,
> 
> Does anyone can say me when the driver will be integrated on linux kernel and where can we get it  from the linux source code?

 Hi Mathias, I'll work with you this week to get this pushed to the security-next tree.  From there the code is pushed to Linus' tree.

Kent

> Thanks,
> 
> Mathias Leblanc
> 
> -----Original Message-----
> From: Kent Yoder [mailto:key@...ux.vnet.ibm.com]
> Sent: 14 November, 2012 23:07
> To: Mathias LEBLANC
> Cc: Rajiv Andrade; Marcel Selhorst; Sirrix AG; 
> tpmdd-devel@...ts.sourceforge.net; Debora Velarde; 
> linux-kernel@...r.kernel.org; Jean-Luc BLANC
> Subject: Re: [PATCH 1/1] TPM: STMicroelectronics ST33 I2C
> 
> Hi Mathias,
> 
> On Wed, Nov 14, 2012 at 03:31:42PM +0100, Mathias Leblanc wrote:
> >  * STMicroelectronics version 1.2.0, Copyright (C) 2010
> >  * STMicroelectronics comes with ABSOLUTELY NO WARRANTY.
> >  * This is free software, and you are welcome to redistribute it
> >  * under certain conditions.
> > 
> > This is the driver for TPM chip from ST Microelectronics.
> > 
> > If you have a TPM security chip from STMicroelectronics working with 
> > an I2C, in menuconfig or .config choose the tpm driver on device --> 
> > tpm and activate the protocol of your choice before compiling the 
> > kernel.
> > The driver will be accessible from within Linux.
> > 
> > Tested on linux x86/x64, beagleboard REV B & XM REV C and CHROMIUM 
> > OS
> 
>   Getting some build errors here:
> 
> drivers/char/tpm/tpm_stm_st33_i2c.c: In function ‘__check_interrupts’:
> drivers/char/tpm/tpm_stm_st33_i2c.c:615:1: warning: return from 
> incompatible pointer type [enabled by default]
> drivers/char/tpm/tpm_stm_st33_i2c.c: In function ‘__check_power_mgt’:
> drivers/char/tpm/tpm_stm_st33_i2c.c:619:1: warning: return from 
> incompatible pointer type [enabled by default]
> drivers/char/tpm/tpm_stm_st33_i2c.c: In function ‘tpm_st33_i2c_probe’:
> drivers/char/tpm/tpm_stm_st33_i2c.c:725:3: warning: suggest 
> parentheses around arithmetic in operand of ‘|’ [-Wparentheses]
> drivers/char/tpm/tpm_stm_st33_i2c.c: In function
> ‘tpm_st33_i2c_pm_suspend’:
> drivers/char/tpm/tpm_stm_st33_i2c.c:826:3: error: too many arguments to function ‘tpm_pm_suspend’
> In file included from drivers/char/tpm/tpm_stm_st33_i2c.h:55:0,
>                  from drivers/char/tpm/tpm_stm_st33_i2c.c:35:
> 		 drivers/char/tpm/tpm.h:326:12: note: declared here
> 		 drivers/char/tpm/tpm_stm_st33_i2c.c: In function
> 		 ‘tpm_st33_i2c_pm_resume’:
> 		 drivers/char/tpm/tpm_stm_st33_i2c.c:855:3: error:
> 		 implicit declaration of function
> 		 ‘tpm_continue_selftest’
> 		 [-Werror=implicit-function-declaration]
> 
> [cut]
> > +/*
> > + * _wait_for_interrupt_serirq_timeout
> > + * @param: tpm, the chip description
> > + * @param: timeout, the timeout of the interrupt
> > + * @return: the status of the interruption.
> > + */
> > +static int _wait_for_interrupt_serirq_timeout(struct tpm_chip *chip,
> > +						unsigned long timeout)
> > +{
> > +	int status;
> > +	struct i2c_client *client;
> > +	struct st33zp24_platform_data *pin_infos;
> > +
> > +	client = (struct i2c_client *) chip->vendor.iobase;
> > +	pin_infos = client->dev.platform_data;
> > +
> > +	status = wait_for_completion_interruptible_timeout(
> > +					&pin_infos->irq_detection,
> > +						timeout);
> 
>   status should be a long here.
> 
> [cut]
> > +
> > +	if (client == NULL) {
> > +		pr_info("client is NULL. exiting.\n");
> > +		err = -ENODEV;
> > +		goto end;
> > +	}
> > +
> > +	if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) {
> > +		pr_info("client not i2c capable\n");
> > +		err = -ENODEV;
> > +		goto end;
> > +	}
> > +
> > +	chip = tpm_register_hardware(&client->dev, &st_i2c_tpm);
> > +	if (!chip) {
> > +		pr_info("fail chip\n");
> 
>   Please use dev_info() in place of pr_info().
> 
> Thanks,
> Kent
>