lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <50B3C13D.1050704@infradead.org>
Date:	Mon, 26 Nov 2012 11:21:33 -0800
From:	Randy Dunlap <rdunlap@...radead.org>
To:	Linus Walleij <linus.walleij@...aro.org>
CC:	Rabin Vincent <rabin.vincent@...ricsson.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] mfd: fix stmpe.c build when OF is not enabled

On 11/13/2012 05:35 AM, Linus Walleij wrote:

> On Mon, Nov 12, 2012 at 6:20 PM, Randy Dunlap <rdunlap@...radead.org> wrote:
> 
>> From: Randy Dunlap <rdunlap@...radead.org>
>>
>> Fix build errors when CONFIG_OF is not enabled by including
>> <linux/of.h> (needs to be added in any case).
>> An alternative fix could be to make the driver depend on OF.
>>
>> drivers/mfd/stmpe.c:1025:2: error: implicit declaration of function 'of_property_read_u32'
>> drivers/mfd/stmpe.c:1030:2: error: implicit declaration of function 'for_each_child_of_node'
>> drivers/mfd/stmpe.c:1030:36: error: expected ';' before '{' token
>>
>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>> Cc: Rabin Vincent <rabin.vincent@...ricsson.com>
>> Cc: Samuel Ortiz <sameo@...ux.intel.com>
> 
> Acked-by: Linus Walleij <linus.walleij@...aro.org>




ping?

This patch is still needed in linux-next.

---
From: Randy Dunlap <rdunlap@...radead.org>

Fix build errors when CONFIG_OF is not enabled by including
<linux/of.h> (needs to be added in any case).
An alternative fix could be to make the driver depend on OF.

drivers/mfd/stmpe.c:1025:2: error: implicit declaration of function 'of_property_read_u32'
drivers/mfd/stmpe.c:1030:2: error: implicit declaration of function 'for_each_child_of_node'
drivers/mfd/stmpe.c:1030:36: error: expected ';' before '{' token

Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Cc: Rabin Vincent <rabin.vincent@...ricsson.com>
Cc: Samuel Ortiz <sameo@...ux.intel.com>
Acked-by: Linus Walleij <linus.walleij@...aro.org>
---
 drivers/mfd/stmpe.c |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20121112.orig/drivers/mfd/stmpe.c
+++ linux-next-20121112/drivers/mfd/stmpe.c
@@ -13,6 +13,7 @@
 #include <linux/interrupt.h>
 #include <linux/irq.h>
 #include <linux/irqdomain.h>
+#include <linux/of.h>
 #include <linux/pm.h>
 #include <linux/slab.h>
 #include <linux/mfd/core.h>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ