linux-kernel - Re: [PATCH -next] mfd: fix stmpe.c build when OF is not enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121126210723.GX12685@sortiz-mobl>
Date:	Mon, 26 Nov 2012 22:07:23 +0100
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Randy Dunlap <rdunlap@...radead.org>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	Rabin Vincent <rabin.vincent@...ricsson.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] mfd: fix stmpe.c build when OF is not enabled

Hi Randy,

On Mon, Nov 26, 2012 at 11:21:33AM -0800, Randy Dunlap wrote:
> On 11/13/2012 05:35 AM, Linus Walleij wrote:
> 
> > On Mon, Nov 12, 2012 at 6:20 PM, Randy Dunlap <rdunlap@...radead.org> wrote:
> > 
> >> From: Randy Dunlap <rdunlap@...radead.org>
> >>
> >> Fix build errors when CONFIG_OF is not enabled by including
> >> <linux/of.h> (needs to be added in any case).
> >> An alternative fix could be to make the driver depend on OF.
> >>
> >> drivers/mfd/stmpe.c:1025:2: error: implicit declaration of function 'of_property_read_u32'
> >> drivers/mfd/stmpe.c:1030:2: error: implicit declaration of function 'for_each_child_of_node'
> >> drivers/mfd/stmpe.c:1030:36: error: expected ';' before '{' token
> >>
> >> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> >> Cc: Rabin Vincent <rabin.vincent@...ricsson.com>
> >> Cc: Samuel Ortiz <sameo@...ux.intel.com>
> > 
> > Acked-by: Linus Walleij <linus.walleij@...aro.org>
> 
> 
> 
> 
> ping?
> 
> This patch is still needed in linux-next.
Applied and pushed, thanks a lot.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/