linux-kernel - Re: [PATCH 1/1] ARM: ux500: Fix u9540 booting issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121127130311.GE2013@gmail.com>
Date:	Tue, 27 Nov 2012 13:03:11 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linus.walleij@...ricsson.com
Subject: Re: [PATCH 1/1] ARM: ux500: Fix u9540 booting issues

On Tue, 27 Nov 2012, Arnd Bergmann wrote:

> On Tuesday 27 November 2012, Lee Jones wrote:
> 
> > The u9540 stopped booting after the v3.7 merge window due to
> > a lack of common clk support and early PRCMU initialisation.
> > In this patch we rectify these issues, placing the u9540
> > development board back into a successfully booting state.
> 
> > -       if (cpu_is_u8500_family())
> > +       if (cpu_is_u8500_family() || cpu_is_u9540())
> >                 u8500_clk_init();
> > -       else if (cpu_is_u9540())
> > -               u9540_clk_init();
> >         else if (cpu_is_u8540())
> >                 u8540_clk_init();
> 
> It certainly doesn't /look/ right, even if it works.  Can you explain why
> u8540_clk_init works and u9540_clk_init doesn't?

Because it's empty. :)

Common clk doesn't support the u9540 yet, and even when it does,
most (all?) of the clocks will be identical to the u9540 in any
case.

I believe Linus wants to apply this with a TODO, to ensure the
board is at least bootable. This whole section is in the wrong
place anyway IMHO, and needs moving out to somewhere less hacky,
rather than initialising clocks and the PRCMU from .init_irq.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/