linux-kernel - Re: [PATCH v8 1/2] x86/kexec: add a new atomic notifier list for kdump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <50B41D1C.1010802@cn.fujitsu.com>
Date:	Tue, 27 Nov 2012 09:53:32 +0800
From:	Zhang Yanfei <zhangyanfei@...fujitsu.com>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
CC:	Gleb Natapov <gleb@...hat.com>, "x86@...nel.org" <x86@...nel.org>,
	"kexec@...ts.infradead.org" <kexec@...ts.infradead.org>,
	Marcelo Tosatti <mtosatti@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>
Subject: Re: [PATCH v8 1/2] x86/kexec: add a new atomic notifier list for
 kdump

于 2012年11月27日 09:49, Eric W. Biederman 写道:
> Zhang Yanfei <zhangyanfei@...fujitsu.com> writes:
> 
>> So in summary,
>>
>> 1. a specific callback function instead of a notifier?
> 
> Yes.
> 
>> 2. Instead of calling vmclear_local_loaded_vmcss, the vmclear operation
>>    will just call the vmclear on every vmcss loaded on the cpu?
>>
>>    like below:
>>
>>    static void crash_vmclear_local_loaded_vmcss(void)
>>    {
>>         int cpu = raw_smp_processor_id();
>>         struct loaded_vmcs *v, *n;
>>
>>         if (!crash_local_vmclear_enabled(cpu))
>>                 return;
>>
>>         list_for_each_entry_safe(v, n, &per_cpu(loaded_vmcss_on_cpu, cpu),
>>                                  loaded_vmcss_on_cpu_link)
>>                 vmcs_clear(v->vmcs);
>>    }
>>
>>    right?
> 
> Yeah that looks good.  I would do list_for_each_entry because the list
> isn't changing.

OK.

I will update the patch and resend it.

Zhang


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/