linux-kernel - Re: [PATCH 5/5] serial: 8250_dw: Set FIFO size dynamically

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121128131826.38391319@pyramind.ukuu.org.uk>
Date:	Wed, 28 Nov 2012 13:18:26 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Alan Cox <alan@...ux.intel.com>,
	Jamie Iles <jamie@...ieiles.com>, linux-serial@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 5/5] serial: 8250_dw: Set FIFO size dynamically

> +	if (!reg || (reg & 0xff) != '*')
> +		return;
> +

That looks bogus. If reg == 0 then reg & 0xFF != '*'

So why the double test ?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/