lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 28 Nov 2012 15:37:04 +0200 From: Heikki Krogerus <heikki.krogerus@...ux.intel.com> To: Alan Cox <alan@...rguk.ukuu.org.uk> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Alan Cox <alan@...ux.intel.com>, Jamie Iles <jamie@...ieiles.com>, linux-serial@...r.kernel.org, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 5/5] serial: 8250_dw: Set FIFO size dynamically On Wed, Nov 28, 2012 at 01:18:26PM +0000, Alan Cox wrote: > > + if (!reg || (reg & 0xff) != '*') > > + return; > > + > > That looks bogus. If reg == 0 then reg & 0xFF != '*' > > So why the double test ? No reason. It is something I forgot to cleanup. I'll resend this. Thanks! -- heikki -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists