linux-kernel - Re: [PATCH] cgroup: avoid creating degenerate allcg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121128182911.GA24683@htj.dyndns.org>
Date:	Wed, 28 Nov 2012 10:29:11 -0800
From:	Tejun Heo <tj@...nel.org>
To:	Greg Thelen <gthelen@...gle.com>
Cc:	Li Zefan <lizefan@...wei.com>,
	containers@...ts.linux-foundation.org, cgroups@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cgroup: avoid creating degenerate allcg_list

Hey, Greg.

On Wed, Nov 28, 2012 at 10:26:32AM -0800, Greg Thelen wrote:
> Before this patch init_cgroup_root() created a degenerate list by
> first inserting a element into allcg_list and then initializing the
> inserted list element.  The initialization reset the element's
> prev/next fields forming a degenerate list where allcg_list pointed to
> element, but element pointed to itself.  This problem was introduced
> in 2243076ad128 "cgroup: initialize cgrp->allcg_node in
> init_cgroup_housekeeping()".  CONFIG_DEBUG_LIST reported a list_add
> corruption in cgroup_mkdir() running next-20121127 (ce2931a).
> 
> This patch fixes the problem by performing element initialization
> before insertion.

You're beaten by Li Zhong by 9 hrs.  :)

 http://thread.gmane.org/gmane.linux.kernel.next/25096

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/