linux-kernel - [PATCH] cgroup: avoid creating degenerate allcg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1354127192-22153-1-git-send-email-gthelen@google.com>
Date:	Wed, 28 Nov 2012 10:26:32 -0800
From:	Greg Thelen <gthelen@...gle.com>
To:	Tejun Heo <tj@...nel.org>, Li Zefan <lizefan@...wei.com>
Cc:	containers@...ts.linux-foundation.org, cgroups@...r.kernel.org,
	linux-kernel@...r.kernel.org, Greg Thelen <gthelen@...gle.com>
Subject: [PATCH] cgroup: avoid creating degenerate allcg_list

Before this patch init_cgroup_root() created a degenerate list by
first inserting a element into allcg_list and then initializing the
inserted list element.  The initialization reset the element's
prev/next fields forming a degenerate list where allcg_list pointed to
element, but element pointed to itself.  This problem was introduced
in 2243076ad128 "cgroup: initialize cgrp->allcg_node in
init_cgroup_housekeeping()".  CONFIG_DEBUG_LIST reported a list_add
corruption in cgroup_mkdir() running next-20121127 (ce2931a).

This patch fixes the problem by performing element initialization
before insertion.

Signed-off-by: Greg Thelen <gthelen@...gle.com>
---
 kernel/cgroup.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 01d5342..ece60d4 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -1394,6 +1394,7 @@ static void init_cgroup_root(struct cgroupfs_root *root)
 {
 	struct cgroup *cgrp = &root->top_cgroup;
 
+	init_cgroup_housekeeping(cgrp);
 	INIT_LIST_HEAD(&root->subsys_list);
 	INIT_LIST_HEAD(&root->root_list);
 	INIT_LIST_HEAD(&root->allcg_list);
@@ -1401,7 +1402,6 @@ static void init_cgroup_root(struct cgroupfs_root *root)
 	cgrp->root = root;
 	cgrp->top_cgroup = cgrp;
 	list_add_tail(&cgrp->allcg_node, &root->allcg_list);
-	init_cgroup_housekeeping(cgrp);
 }
 
 static bool init_root_id(struct cgroupfs_root *root)
-- 
1.7.7.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/