linux-kernel - Re: [regression] 3.7+ suspend to RAM/offline CPU fails with nmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.02.1211282136410.2701@ionos>
Date:	Wed, 28 Nov 2012 21:37:10 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Joseph Salisbury <joseph.salisbury@...onical.com>
cc:	Norbert Warmuth <nwarmuth@...nline.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [regression] 3.7+ suspend to RAM/offline CPU fails with
 nmi_watchdog=0 (bisected)

On Wed, 28 Nov 2012, Joseph Salisbury wrote:
> On 11/23/2012 08:11 AM, Norbert Warmuth wrote:
> > Thomas Gleixner writes:
> > > On Wed, 21 Nov 2012, Norbert Warmuth wrote:
> > > > 3.7-rc6 booted with nmi_watchdog=0 fails to suspend to RAM or
> > > > offline CPUs. It's reproducable with a KVM guest and physical
> > > > system.
> > > Does the patch below fix it?
> > Yes.
> > 
> > - Norbert
> > 
> > > diff --git a/kernel/watchdog.c b/kernel/watchdog.c
> > > index 9d4c8d5..e3ef521 100644
> > > --- a/kernel/watchdog.c
> > > +++ b/kernel/watchdog.c
> > > @@ -368,6 +368,9 @@ static void watchdog_disable(unsigned int cpu)
> > >   {
> > >   	struct hrtimer *hrtimer = &__raw_get_cpu_var(watchdog_hrtimer);
> > >   +	if (!watchdog_enabled)
> > > +		return;
> > > +
> > >   	watchdog_set_prio(SCHED_NORMAL, 0);
> > >   	hrtimer_cancel(hrtimer);
> > >   	/* disable the perf event */
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@...r.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/
> 
> Hi Thomas,
> 
> Your patch also fixes a bug[0] reported against Ubuntu.  I assume the window
> for v3.7 is closed.  Will you be submitting this patch for inclusion in v3.8?

Sure, with a stable tag so it gets back into 3.7

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/