linux-kernel - Re: [RFC 1/2] clk: use struct clk only for external API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 28 Nov 2012 22:26:12 +0100
From:	Rabin Vincent <rabin@....in>
To:	viresh kumar <viresh.kumar@...aro.org>
Cc:	Mike Turquette <mturquette@...com>,
	Russell King <linux@....linux.org.uk>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC 1/2] clk: use struct clk only for external API

2012/11/28 viresh kumar <viresh.kumar@...aro.org>:
> On Wed, Nov 28, 2012 at 9:31 PM, viresh kumar <viresh.kumar@...aro.org> wrote:
>> On Wed, Nov 28, 2012 at 5:22 PM, Rabin Vincent
>> Isn't something wrong here? For common clk case shouldn't
>> this be:
>>
>>> +#define clk_to_clk_core(clk)  (&clk->clk)
>>> +#define clk_core_to_clk(core) (container_of(clk, ...))  //not getting into the exact format here
>>
>> Sorry, if i am missing basics.
>
> Ok. I saw these getting updated in 2/2. But it means this individual patch
> is broken and this is not allowed i believe.

It would be better to use container_of / &clk->clk, yes.  I wouldn't
really describe it as "broken" though since it works fine as it is,
since it's the first and only element.  I will change it anyway.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/