linux-kernel - Re: IRQ subsystem menu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20121129203242.6D6CD3E09C2@localhost>
Date:	Thu, 29 Nov 2012 20:32:42 +0000
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Michal Marek <mmarek@...e.cz>,
	Paul Thompson <set.mailinglist@...il.com>
Cc:	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: IRQ subsystem menu

On Mon, 29 Oct 2012 15:03:08 +0100, Michal Marek <mmarek@...e.cz> wrote:
> (Adding lkml and Thomas as IRQ subsystem maintainer to CC)
> 
> On Sun, Oct 21, 2012 at 03:40:16AM -0400, Paul Thompson wrote:
> > 	Hi;
> > 
> > 	In menuconfig, General setup -> IRQ subsystem, there are two
> > possible menu-items. One depends partly on IRQ_DOMAIN, and the other
> > on MAY_HAVE_SPARSE_IRQ.
> > 
> > 	On the x86-64 arch, neither of these seems to be set, so the
> > menu entry is blank if entered (displaying an odd ^@ if you try to
> > navigate up or down. And sometimes some screen garbage on the sides.)
> > 
> > 	Previously (in the 3.2 kernel at least) this menu used to be
> > populated by the "Support sparse IRQ numbering" menu-item, which
> > at that time depended on HAVE_SPARSE_IRQ, and was forced to YES.
> > 
> > 	I do not know if the current behaviour is intended, but it
> > is ugly and confusing to be confronted with a blank menu page.
> > 
> > 	Ideally, the "IRQ subsystem" menu would not even show up
> > if it would contain no menu-items, but I do not know enough to
> > formulate that constraint.

First, move the 'menu "IRQ subsystem"' line does to right before the
IRQ_DOMAIN_DEBUG line so that it wraps the options that matter, then you
can add a "depends on MAY_HAVE_SPARSE_IRQ || IRQ_DOMAIN" line right
below the menu item.

You'll also need to move the IRQ_FORCED_THREADING line out from inside
the menu block.

Try it out and let me know how it goes.

g.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/