linux-kernel - Re: IRQ subsystem menu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 5 Dec 2012 21:16:20 -0500
From:	Paul Thompson <set48035@...il.com>
To:	Grant Likely <grant.likely@...retlab.ca>
Cc:	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: IRQ subsystem menu

Grant Likely <grant.likely@...retlab.ca>, on Thu  2012.11.29 said:
> On Mon, 29 Oct 2012 15:03:08 +0100, Michal Marek <mmarek@...e.cz> wrote:
> > (Adding lkml and Thomas as IRQ subsystem maintainer to CC)
> > 
> > On Sun, Oct 21, 2012 at 03:40:16AM -0400, Paul Thompson wrote:
> > > 	Hi;
> > > 
> > > 	In menuconfig, General setup -> IRQ subsystem, there are two
> > > possible menu-items. One depends partly on IRQ_DOMAIN, and the other
> > > on MAY_HAVE_SPARSE_IRQ.
> > > 
[...]
> > > 
> > > 	Ideally, the "IRQ subsystem" menu would not even show up
> > > if it would contain no menu-items, but I do not know enough to
> > > formulate that constraint.
> 
> First, move the 'menu "IRQ subsystem"' line does to right before the
> IRQ_DOMAIN_DEBUG line so that it wraps the options that matter, then you
> can add a "depends on MAY_HAVE_SPARSE_IRQ || IRQ_DOMAIN" line right
> below the menu item.
> 
> You'll also need to move the IRQ_FORCED_THREADING line out from inside
> the menu block.
> 
> Try it out and let me know how it goes.
> 
> g.

	Hi;

	The logic makes sense to me, and makes the menus appearance
dependent on if either option setting can exist. So, on my system,
the IRQ subsystem menu does not appear.

Paul

See if this attached patch looks right:

View attachment "irq-menu.patch" of type "text/plain" (938 bytes)