[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1354563168-6609-1-git-send-email-olaf@aepfle.de>
Date: Mon, 3 Dec 2012 20:32:48 +0100
From: Olaf Hering <olaf@...fle.de>
To: konrad.wilk@...cle.com
Cc: linux-kernel@...r.kernel.org, xen-devel@...ts.xen.org,
jbeulich@...e.com, Olaf Hering <olaf@...fle.de>
Subject: [PATCH] xen/blkback: do not leak mode property
be->mode is obtained from xenbus_read, which does a kmalloc for the
message body. The short string is never released, so do it on blkbk
remove.
Signed-off-by: Olaf Hering <olaf@...fle.de>
---
!! Not compile tested !!
drivers/block/xen-blkback/xenbus.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c
index f58434c..a6585a4 100644
--- a/drivers/block/xen-blkback/xenbus.c
+++ b/drivers/block/xen-blkback/xenbus.c
@@ -366,6 +366,7 @@ static int xen_blkbk_remove(struct xenbus_device *dev)
be->blkif = NULL;
}
+ kfree(be->mode);
kfree(be);
dev_set_drvdata(&dev->dev, NULL);
return 0;
--
1.8.0.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists